DragonFlyBSD / DPorts

The dedicated application build system for DragonFly BSD
Other
91 stars 43 forks source link

Latest dports master kills hw accel on i915 and Radeon 4xxx #100

Closed davshao closed 10 years ago

davshao commented 10 years ago

After using portmaster -d -a to update dports using the latest dports master, various machines running either Intel integrated graphics or using a Radeon 4xxx graphics card no longer have hardware acceleration, instead with xorg using only VESA. Reverting back to dports compiled with the previous set of revisions ending around

Author: DPorts Builder nobody@home.ok Date: Sun Jul 20 02:27:59 2014 -0700

Tweak net/libdnet version 1.12

immediately restores DRM GEM on Intel and KMS on Radeon 4xxx. This is using DragonFly 3.9-DEVELOPMENT master through

commit b5c29a3405686a232e667f64c5ecf10bac5f8907 Date: Fri Jul 25 08:18:59 2014 +0200

drm/i915: Sync intel_ringbuffer.c with Linux 3.8.13
ftigeot commented 10 years ago

The DragonFly-specific patch file graphics/libdrm/dragonfly/extra-xf86drmMode.c has been removed on July 21. I wouldn't be surprised if this is what causes KMS to not be enabled anymore.

ftigeot commented 10 years ago

A fix has been pushed to Deltaports and submitted to the upstream libdrm project.

Link to upstream patch: http://lists.freedesktop.org/archives/dri-devel/2014-July/064728.html

jrmarino commented 10 years ago

I removed the extra patch (without looking at it) because it disappeared from FreeBSD. FTR

ftigeot commented 10 years ago

That's all right, FreeBSD folks managed to upstream their patch.

jrmarino commented 10 years ago

is it correct to convert the "extra" patch to an unconditional patch? I thought this patch was applied as a function of DFLYVERSION (based on __DragonFly_version value)

ftigeot commented 10 years ago

The graphics/libdrm port could previously install two different versions of libdrm, the final version beeing choosen depending on the value of the WITH_NEW_XORG variable. The patch was specific to the WITH_NEW_XORG version of libdrm and thus had to be specially handled. FreeBSD ports people have now decided to use a single version of libdrm everywhere; the patch doesn't require special treatment anymore and can just be put into the dragonfly/ directory.

davshao commented 10 years ago

For now hasn't FreeBSD ports simply reverted the change to libdrm? This reversion was done very quickly when they discovered the undesirable effects.

http://svnweb.freebsd.org/ports/head/graphics/libdrm/

Also I think reverting downgrades the version of libdrm even for kms from 2.4.54 back to 2.4.52.

ftigeot commented 10 years ago

It's not clear what the FreeBSD issue with xf86-video-ati and the old Xorg versions was. Either reverting or updating the port with the patch I put into Deltaports should be fine IMHO.

jrmarino commented 10 years ago

I think I'm going to attempt to put it back how it was before.

jrmarino commented 10 years ago

I'm removing the need for a patch at all by moving the fix upstream (To FreeBSD): http://www.freshports.org/commit.php?category=graphics&port=libdrm&files=yes&message_id=201408020852.s728qWur043045@svn.freebsd.org

jrmarino commented 10 years ago

hopefully this is correct: https://github.com/DragonFlyBSD/DPorts/commit/fe30ac00eb9fefeda35e1d240289637f76f45cf8

Closing with optimism that it is.