search

DragonFlyBSD / DPorts

The dedicated application build system for DragonFly BSD
Other
91 stars 43 forks source link

submitting new port devel/libsearpc #35

Closed tuxillo closed 11 years ago

tuxillo commented 11 years ago

Hi,

Tarball containing the port: http://leaf.dragonflybsd.org/~tuxillo/archive/dports/libsearpc.tgz

Cheers, Antonio Huete

jrmarino commented 11 years ago

hint for future: install ports-mgmt/portlint Run portlint in proposed port prior to submission

jrmarino commented 11 years ago

There were a few "fatal" errors with portlint. The most interesting is DEMO option is indicated but not defined. I think it's a template leftover so I'm going to remove it.

jrmarino commented 11 years ago

This port had numerous problems with it. It did not build in a jail, it was missing several build dependencies. The pkg-plist was a disaster. I spent more than 90 minutes fixing this contribution. https://github.com/jrmarino/DPorts/commit/851c3f65463c397ad69607655cef1e5860386eaa

Perhaps now you can see why "free" isn't free. You thought it was perfect, it wasn't even close. I was happy to explain the issues so you could improve but you rejected this good will. Enjoy. I won't even consider looking at any more until it passing poudriere checks.