sysutils/ipmitool build failure

DragonFlyBSD / DPorts

The dedicated application build system for DragonFly BSD

Other

89 stars 44 forks source link

sysutils/ipmitool build failure #47

Closed ftigeot closed 11 years ago

ftigeot commented 11 years ago

sysutils/ipmitool fails to build with this error:

ipmishell.c: In function 'ipmi_shell_main': ipmishell.c:113: error: 'rl_event_hook' undeclared (first use in this function)

rl_event_hook is declared in /usr/local/include/readline/readline.h
ipmishell.c includes <readline/readline.h>
unfortunately, a /usr/include/readline/readline.h file is also present and is most likely included instead of the expected one in /usr/local

jrmarino commented 11 years ago

this is a very common problem. Often FreeBSD actually patches the port to force it to use the system readline and the patch has to be removed. Other times the settings in the makefile are wrong, or it's missing configure args. I have fixed a dozen of similar breakage.

sepherosa commented 11 years ago

I have made it compile, and i have checked the created package works as expected.

http://leaf.dragonflybsd.org/~sephe/ipmitool.tbz

The change is made directly to the Makefile, well, I am not sure about where else to change.

The added lines: LIB_DEPENDS+= readline:${PORTSDIR}/devel/readline CPPFLAGS+= -I${LOCALBASE}/include LDFLAGS+= -L${LOCALBASE}/lib

jrmarino commented 11 years ago

I suspect you can replace all of that with this: "USES+= readline"

sepherosa commented 11 years ago

yeah, that works!

ftigeot commented 11 years ago

Fix pushed to Deltaports. Thanks, John!