DragonFlyBSD / DPorts

The dedicated application build system for DragonFly BSD
Other
91 stars 43 forks source link

Add devel/py-slowaes #52

Closed kyuupichan closed 11 years ago

kyuupichan commented 11 years ago

Adds a new package py-slowaes. First of two new packages required for the electrum bitcoin client.

I'm not sure why your base repo doesn't have the patch file from your prior merge of security/keepassx. Am I doing something wrong? I find this workflow quite confusing.

jrmarino commented 11 years ago

I think you are confused because there are TWO repositories. This one is generated by a machine. The patches, etc, go to https://github.com/jrmarino/DeltaPorts Later those changes are laid over FreeBSD and the resultant is built and imported to DPorts.

and keepassx is imported here: https://github.com/jrmarino/DPorts/commit/cafc72525355a93d3e5fbbbf4d55a349369821a5

Question: Are these new packages not in FreeBSD Ports? Should they be introduced there and then they can flow back to DragonFly?

kyuupichan commented 11 years ago

They can go into FreeBSD ports, but I see such a long list of uncommitted ports that it's discouraging even trying.

On 9 June 2013 17:15, jrmarino notifications@github.com wrote:

I think you are confused because there are TWO repositories. This one is generated by a machine. The patches, etc, go to https://github.com/jrmarino/DeltaPorts Later those changes are laid over FreeBSD and the resultant is built and imported to DPorts.

and keepassx is imported here: cafc725https://github.com/jrmarino/DPorts/commit/cafc72525355a93d3e5fbbbf4d55a349369821a5

Question: Are these new packages not in FreeBSD Ports? Should they be introduced there and then they can flow back to DragonFly?

— Reply to this email directly or view it on GitHubhttps://github.com/jrmarino/DPorts/pull/52#issuecomment-19162493 .

jrmarino commented 11 years ago

That's not a good attitude though, and it forces the burden of support on DragonFly. Plus it can benefit FreeBSD. There are reasons for the long list, and normally it's because the submission is bad. A good package is picked up pretty quickly, especially if it's been tested in say poudriere. Usually a "ping" after 2 weeks is enough to get some action if it wasn't picked up quickly. I'd think something involving bitcoin would get some interest.

kyuupichan commented 11 years ago

OK I will give it a go. I was just doing what you asked, and send-pr is a disincentive to doing anything...

On 9 June 2013 17:22, jrmarino notifications@github.com wrote:

That's not a good attitude though, and it forces the burden of support on DragonFly. Plus it can benefit FreeBSD. There are reasons for the long list, and normally it's because the submission is bad. A good package is picked up pretty quickly, especially if it's been tested in say poudriere. Usually a "ping" after 2 weeks is enough to get some action if it wasn't picked up quickly. I'd think something involving bitcoin would get some interest.

— Reply to this email directly or view it on GitHubhttps://github.com/jrmarino/DPorts/pull/52#issuecomment-19162548 .

jrmarino commented 11 years ago

? use the web interface, it's easy http://www.freebsd.org/send-pr.html

It's just filling out a form. I have literally done this 150 times without any issue. ftigeot was saying that this is possible, but I don't think it should be the first resort. Only if freebsd unreasonably blocks the port should we starting maintaining it on our own.

jrmarino commented 11 years ago

that said, you may want the port reviewed here first. that means using portlint and we'd run it through poudriere to see if it builds cleanly.

kyuupichan commented 11 years ago

Thanks for your help. I've attached a tarball of the 3 packages. Would appreciate your taking a look and trying it out on poudriere.

Neil.

On 9 June 2013 18:19, jrmarino notifications@github.com wrote:

that said, you may want the port reviewed here first. that means using portlint and we'd run it through poudriere to see if it builds cleanly.

— Reply to this email directly or view it on GitHubhttps://github.com/jrmarino/DPorts/pull/52#issuecomment-19163137 .

kyuupichan commented 11 years ago

I missed a dependency on py27-qt4. There may be others missing; it's hard for me to tell, though I suspect that might be it.

Neil.

On 9 June 2013 20:37, Neil kyuupichan@gmail.com wrote:

Thanks for your help. I've attached a tarball of the 3 packages. Would appreciate your taking a look and trying it out on poudriere.

Neil.

On 9 June 2013 18:19, jrmarino notifications@github.com wrote:

that said, you may want the port reviewed here first. that means using portlint and we'd run it through poudriere to see if it builds cleanly.

— Reply to this email directly or view it on GitHubhttps://github.com/jrmarino/DPorts/pull/52#issuecomment-19163137 .

kyuupichan commented 11 years ago

Attached an updated Electrum with the extra dependency. Thanks.

On 9 June 2013 22:14, Neil kyuupichan@gmail.com wrote:

I missed a dependency on py27-qt4. There may be others missing; it's hard for me to tell, though I suspect that might be it.

Neil.

On 9 June 2013 20:37, Neil kyuupichan@gmail.com wrote:

Thanks for your help. I've attached a tarball of the 3 packages. Would appreciate your taking a look and trying it out on poudriere.

Neil.

On 9 June 2013 18:19, jrmarino notifications@github.com wrote:

that said, you may want the port reviewed here first. that means using portlint and we'd run it through poudriere to see if it builds cleanly.

— Reply to this email directly or view it on GitHubhttps://github.com/jrmarino/DPorts/pull/52#issuecomment-19163137 .

jrmarino commented 11 years ago

you said you uploaded a tarball with the three ports? I don't know where to look for it. I don't see it on github.

kyuupichan commented 11 years ago

I attached it to the mail, perhaps that means it is dropped. I don't see a way to upload files to github.

On 9 June 2013 23:17, jrmarino notifications@github.com wrote:

you said you uploaded a tarball with the three ports? I don't know where to look for it. I don't see it on github.

— Reply to this email directly or view it on GitHubhttps://github.com/jrmarino/DPorts/pull/52#issuecomment-19166785 .

jrmarino commented 11 years ago

if you don't have a place you can upload it, then send it to me at draco [at] marino [dot] st

jrmarino commented 11 years ago

All three ports installed cleanly in poudriere in test mode, which is really good. comment 1) the ecdsa port had to go through like 8 mirrors before it finally downloaded. that might be out of your control comment 2) finance/Electrum is capitalized. There aren't many capitalized ports, I'm guess this will be frowned upon. My guess is that distfile was capitalized and you changed to port name to avoid redefining the DISTNAME and workdir, etc. You might want make this lower case and make the necessary adjustments so that it still builds. Other than that suggestion, these look good! I checked the electrum patches too.

kyuupichan commented 11 years ago

Excellent. I'm about to sleep now. Tomorrow shall I open an issue in FreeBSD then? I'll fix the capitalization thing. On Jun 9, 2013 11:40 PM, "jrmarino" notifications@github.com wrote:

All three ports installed cleanly in poudriere in test mode, which is really good. comment 1) the ecdsa port had to go through like 8 mirrors before it finally downloaded. that might be out of your control comment 2) finance/Electrum is capitalized. There aren't many capitalized ports, I'm guess this will be frowned upon. My guess is that distfile was capitalized and you changed to port name to avoid redefining the DISTNAME and workdir, etc. You might want make this lower case and make the necessary adjustments so that it still builds. Other than that suggestion, these look good! I checked the electrum patches too.

— Reply to this email directly or view it on GitHubhttps://github.com/jrmarino/DPorts/pull/52#issuecomment-19167130 .

jrmarino commented 11 years ago

Sure. Open 3 separate PRs, one for each port, but for the first two mention they are dependencies of electrum and for electrum reference the PR numbers of the two dependencies and suggest they be tested together. Nice work. I'm sure it won't get stuck in the queue for too long.

kyuupichan commented 11 years ago

Thanks for your help. All three submitted. Let's see...

On 9 June 2013 23:51, jrmarino notifications@github.com wrote:

Sure. Open 3 separate PRs, one for each port, but for the first two mention they are dependencies of electrum and for electrum reference the PR numbers of the two dependencies and suggest they be tested together. Nice work. I'm sure it won't get stuck in the queue for too long.

— Reply to this email directly or view it on GitHubhttps://github.com/jrmarino/DPorts/pull/52#issuecomment-19167330 .

jrmarino commented 11 years ago

This is being handled upstream: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179447

jrmarino commented 11 years ago

as a post-script: All 3 of these packages were quickly picked up by FreeBSD and are in now in ports. two of them are already in dports (staged branch) but the third missed the cutoff (Electrum) so I'll get it on the next pass.

kyuupichan commented 11 years ago

Yes thanks. I exchanged a few mails with the guy who committed them. On Jun 17, 2013 5:55 PM, "jrmarino" notifications@github.com wrote:

as a post-script: All 3 of these packages were quickly picked up by FreeBSD and are in now in ports. two of them are already in dports (staged branch) but the third missed the cutoff (Electrum) so I'll get it on the next pass.

— Reply to this email directly or view it on GitHubhttps://github.com/jrmarino/DPorts/pull/52#issuecomment-19533084 .