DragonMinded / bemaniutils

A collection of utilities which together make up a hobby game services network and associated utilities for historic games in the BEMANI series.
The Unlicense
220 stars 66 forks source link

SuperNova 2 Support #86

Open DiscoStarslayer opened 7 months ago

DiscoStarslayer commented 7 months ago

I'm not the best pythoner in the world so some of this code might be cringe, however it is working properly for the following:

Features:

I still haven't done the following work:

Todo:

Shoutout to @987123879113 for sharing their research with me on the account binary format and the event logic, was a big help in making this work faster.

I plan on getting this a bit more cleaned up and upstream-able eventually, tackling the todos over time, however the branch is fully functional so it would be a shame to keep it to myself till then.

Open to any and all suggestions on the lack of quality on my python code, there was some fishy stuff with the inheritance that I'm not a big fan of but unsure what fits best with the project's vision.

DragonMinded commented 7 months ago

Hey, thanks for sending this in, this looks promising! Sorry about the slow response, I'm very burned out. I won't be able to merge this without at minimum traffic tests, and unit tests would be a nice bonus (but most non-core stuff doesn't have any since unit testing game responses tends to end up being a change inhibitor). Let me comment inline with your comments.

DiscoStarslayer commented 7 months ago

Hey, thanks for sending this in, this looks promising! Sorry about the slow response, I'm very burned out.

Hey! Thank you very much for taking the time to review! I honestly didn't think I would get a response so quickly, so thanks a lot for that.

And understood with the requirements for merge, I agree with that and will work towards polishing this branch up. Game is already 17 years old so there is no urgency to any of this 😄

Going over your review now 👀