DragonPig42 / pe

0 stars 0 forks source link

Bugs related to duplicate person detection #2

Open DragonPig42 opened 1 year ago

DragonPig42 commented 1 year ago

Steps to reproduce:

  1. Enter prof n/Koro Sensei m/CS3230 p/98663357 e/KoroSensei@gmail.com g/M t/wantedgi t/senseikoro r/5 in the command box.

image.png

  1. Enter prof n/Koro sensei m/CS3230 p/98663357 e/KoroSensei@gmail.com g/M t/wantedgi t/senseikoro r/5 in the command box, this time with a small letter s in the name.

image.png

  1. Since the app has actually detects duplicated person, By looking at the result, it's very obvious these two are the same person just a different case in the name, this leaves some potential duplicate person cases to be undetected. Could add more checks rather than just comparing name to detect duplicate person.

image.png

soc-pe-bot commented 1 year ago

Team's Response

It is written in the user guide that namse are case-sensitive. Hence, same name but different case are deem as different people by the application. Thus, the application would deem the Koro Sensei and koro sensei are 2 different persons and hence update the pie chart.

Furthermore, these extra checks you mentioned are considered as not in scope as they are additional features.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png\

This is listed under guideline for bug triaging, so in my opinion it should still be consider a feature flaw.

Furthermore, since the app allows to detect duplicate person, it will not make sense to let two person have same phone number and email because these should be the unique attributes. As regard to the photo you posted for response.NotInScope, I believe there are two extra checks for the condition to be satisfied, in my opinion they are not satisficed because you never specified in the UG that two person can have the same phone number and email or mentioned it will be coming in a future version. In addition, no error message is shown and the operation did not fail when I add them.

image.png