search

DragonSurvivalTeam / DragonSurvival

Other
51 stars 39 forks source link

Cleaned up DragonBallEntity code and fixed #456 #465

Closed seelderr closed 6 months ago

seelderr commented 6 months ago

Fixed inconsistent explosion damage with FireBallEntity, and prevented dragons from being able to damage themselves with their own explosions.

seelderr commented 6 months ago

fixes #456

seelderr commented 6 months ago

going to update this more tommorow. there is an issue with the self-damage prevention code at the moment: if the owner of the explosion is the player, it actually causes them to not be included in the check that deals damage to entities when explosion() is called.

so with current behavior the player actually can't damage themselves anyways. might scrap the SubscribeEvent and just let all dragon projectiles not be able to damage the owner, or work out some more complex solution here.

BlackAures1 commented 6 months ago

I'm fine with all projectiles not doing damage. Can this be added as a config option?

seelderr commented 6 months ago

ok, fixed up a few bugs with the implementation and removed the config option for cave dragons. the reason being that the fireball does fire damage, which the cave dragon is already immune to. so i'd either have to change the damage type or write some code that would make it ignore resistance for just the cave dragon that shot it. which feels like more effort than it is worth for a non-default option, so i just removed the config for cave dragons.

should be ready to merge now if there are no other issues