Misc clean up

[SiverDX]

• fix lava vision when in lava
• switch vehicle whitelist to entity tag
• clean up some item tags
• clean up MixinPlayer
• clean up MixinItemBlockRenderTypes
• clean up MixinEntity

[SiverDX]

Also atm when spawning a knight the game crashes due to missing model json

[seelderr]

that is fine, that whole section is under construction

[SiverDX]

personally I disagree just makes it harder to differentiate if all files start with mixin

[seelderr]

personally I disagree just makes it harder to differentiate if all files start with mixin

we have been naming all of our mixin files Mixin(name), why change now?

it is also pretty normal conventions, all the other mods i've worked on do the same format of Mixin(name)

[seelderr]

if you do want to change the format, rename all of the mixin files so it is consistent

[SiverDX]

it is also pretty normal conventions, all the other mods i've worked on do the same format of Mixin(name)

fabric api (the official one) doesn't, neither do sodium, apotheosis dev or modernfix dev

we have been naming all of our mixin files Mixin(name), why change now?

because in general the code base could need some cleanup especially in formatting etc

[SiverDX]

if you do want to change the format, rename all of the mixin files so it is consistent

the plan would be to eventually go through all mixins and do that

[seelderr]

it is also pretty normal conventions, all the other mods i've worked on do the same format of Mixin(name)

fabric api (the official one) doesn't, neither do sodium, apotheosis dev or modernfix dev

we have been naming all of our mixin files Mixin(name), why change now?

because in general the code base could need some cleanup especially in formatting etc

go for the change, i'm convinced, i might've been a bit mistaken. just make sure to rename them all like i said.