DragonSurvivalTeam / DragonSurvival

Other
49 stars 41 forks source link

[1.20.1 Bug] Some attributes don't update when changing dragon body type. #609

Open KJEntytek303 opened 2 months ago

KJEntytek303 commented 2 months ago

■ Your Discord ID or other contacts

kjentytek303

■ Dragon Survival version

EDIT2: All Dragon Survival versions from DragonSurvival-1.20.1-11.06.2024.jar to DragonSurvival-1.20.1-18.07.2024_fix.jar

■ Forge/Neoforge version

Forge 1.20.1-47.3.5

■ Single game or server?

Single-player (Default)

■ Describe the bug

The run speed modifier is not changed when changing dragon body type. It can only be updated by dying. Reloading a world seems to reset it do default (1.0 i think?) If for example, you choose with northern body with 0.5 run modifier, then switch to south with 1.5 run modifier, you will still have 0.5 run modifier applied. Doesn't matter if changing between different types of dragons (forest -> cave). If you die, everything is set correctly, as long as you don't change dragon body type again.

Save growth stage and save abilities were enabled in config.

EDIT: When the mod is isolated (Loaded only with geckolib and vanilla forge) bug persists.

■ Crash Report File and Logs

latest.log

KJEntytek303 commented 2 months ago

This also seems to affect max hp and step height attributes, and the only mitigation i can think of is /gamerule keepinventory true + /kill, which is unacceptable on most servers and singleplayer worlds (tested only on the newest version of DS)