DragonSurvivalTeam / DragonSurvival

Other
49 stars 41 forks source link

[1.20.1 Bug]: spike ability being used multiple times in a row when there's lag #651

Open FuryJack07 opened 4 weeks ago

FuryJack07 commented 4 weeks ago

■ Your Discord ID or other contacts

FuryJack07#4376 on discord

■ Dragon Survival version

DragonSurvival-1.20.1-18.07.2024.jar

■ Forge/Neoforge version

Forge 47.3.5

■ Single game or server?

Single-player (Default)

■ Describe the bug

Sometimes, (when there's quite a bit of server side lag, usually starting at 10 TPS) when holding down the ability button on the spike ability as a forest dragon during the cooldown, when the cooldown ends, mana might be used multiple times in a row, with the spike ability being used only once.

it's not a huge problem, but it is something that might be worth looking into

■ Crash Report File and Logs

not applicable

FuryJack07 commented 4 weeks ago

ok, small thing, I was wrong about the ability being only used once. it IS used multiple times

here's how to best reproduce it: take a lower end computer (something like a laptop or something) to make the next step easier select forest dragon, any body type (if you don't choose one that increases mana you'll need to get some experience first) cause a lot of lag (either by summoning a lot of mobs or by installing laggy mods) use the spike ability during the cooldown, hold down the ability button (if you see "the ability is not ready yet (n.n)" with n.n being the cooldown quickly going down, you got it) notice that, if there was enough lag, when the cooldown was over and the ability was used automatically your mana went down multiple times, and there are multiple spikes present, meaning the ability was used multiple times without the cooldown.

FuryJack07 commented 4 weeks ago

ok, no need to be at the end of the cooldown, just hold down the ability button when it's ready and if there's enough lag it'll be used twice or more

seelderr commented 1 week ago

Abilities changed a lot in 1.21, will need a retest