search

DragonTechMC / DTPunishment

Sponge API 5/7 - Punishment and Chat Filter Plugin
http://www.dragontechmc.com/
4 stars 6 forks source link

Banpoints/mutepoints "milestones" don't always work #20

Closed charlespockert closed 7 years ago

charlespockert commented 7 years ago

When receiving a lot of banpoints/mutepoints the punishment system rounds off to the nearest 10 points (if 10 or over) and looks for a matching setting in the config.

If the user has a lot of mutepoints/banpoints, it can cause any further activity to fail to apply consequences.

It's not going to happen often, if at all, but worth fixing - if for example, the server admins miss a multiple of 10 in the banpoints config, no punishments will be applied until they hit the next 10.

If the config were changed to serialize/deserialize the points as numeric values, greater/less than checks could be used against the number of points, giving more robust checks against the players points.

charlespockert commented 7 years ago

Fixed in 97fda521b91b9b7d28a97e63860da1c87f0ef78b