fix load order so that logging in while in combat doesn't risk taint

Dragondarn / spartanui

Automatically exported from code.google.com/p/spartanui

0 stars 0 forks source link

fix load order so that logging in while in combat doesn't risk taint #21

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

This has existed since the 2.5.x days; due to the way frames are parented we 
can't perform 
scaling and positioning after the player exists in the world. Bartender somehow 
performs 
needed functions before the in-combat lockout period so I need to use a load 
order that 
does the same.

Original issue reported on code.google.com by step...@smluster.com on 14 Sep 2009 at 8:27

GoogleCodeExporter commented 8 years ago

Test notes: do this first before I progress further with any other fixes.

• Export a copy of SpartanUI and PlayerFrames
• remove incombat checks and enable taintlog
• make note of the actions being blocked
• create a debug window with all events registered
• print events and code breakpoints, identify load order of relevant blocked 
actions
• identify location in load order that we can perform said actions safely

if no safe load order can be found, consider moving secureframes to a new 
parent that allows the main 
frame to be adjusted without causing taint. This will probably introduce other 
issues however such as 
frames being improperly scaled or aligned until combat ends

Original comment by step...@smluster.com on 14 Sep 2009 at 8:40

GoogleCodeExporter commented 8 years ago

[deleted comment]

GoogleCodeExporter commented 8 years ago

[deleted comment]

GoogleCodeExporter commented 8 years ago

[deleted comment]

GoogleCodeExporter commented 8 years ago

[deleted comment]

GoogleCodeExporter commented 8 years ago

I was successful in making scale and offset apply after VARIABLES_LOADED and 
before
the player enters combat at login. I tested this by entering combat, 
end-tasking my
client, and logging back in. I was in fact still in combat, and my ui showed up 
as
expected, with the correct scale and offsets.

Original comment by step...@smluster.com on 18 Sep 2009 at 6:32

Changed state: Verify

GoogleCodeExporter commented 8 years ago

verified through personal testing, and limited user response in the forums

Original comment by step...@smluster.com on 6 Oct 2009 at 12:34

Changed state: Complete

GoogleCodeExporter commented 8 years ago

[deleted comment]

GoogleCodeExporter commented 8 years ago

[deleted comment]

GoogleCodeExporter commented 8 years ago

Original comment by step...@smluster.com on 13 Oct 2009 at 3:31

Changed state: Released