class icon on the pet frame doesn't always update

[GoogleCodeExporter]

summon a pet, and then summon a different pet as a warlock. Prefrably with 
both pets being of different class. Targetting said pet shows the correct 
class, but the pet frame shows the class from the previous pet.

Original issue reported on code.google.com by step...@smluster.com on 14 Oct 2009 at 2:10

[GoogleCodeExporter]

The class icon code could make changes to an icon that didn't belong to the 
frame in 
question. I added a line that forces the function to exit if the unit to be 
updated 
doesn't match the frame's unit. This should now be present in r52

Original comment by step...@smluster.com on 14 Oct 2009 at 2:46

• Changed state: Resolved

[GoogleCodeExporter]

Did a double check again today, and class-icon on the pet frame still doesn't 
update for my warlock; I think i 
have an idea what's going on. 

- summon pet => the pet-frame is created
- dismiss pet => pet-frame is destroyed
- summon another pet => new pet-frame created

I the above scenario, the class-icon is generated OK; but when I do it like 
this:

- summon pet 1 => pet frame is created
- summon pet 2 => pet-frame is reused probably (only portrait, name and some 
other things are updated), 
and the ClassIcon part is not re-generated.

Not sure if this helps, but i thought i could right it down; maybe it will help 
nail the "bug" faster.

Original comment by yo3...@gmail.com on 14 Oct 2009 at 11:00

[GoogleCodeExporter]

strange. I will play around with the events again and see if I can make it 
work. I 
don't understand why the class icon doesn't get updated though. I may add some 
debug 
info, and have you test it with the debug so that you can tell me what events 
are fired 
when you switch pets.

What level does a warlock need to be before they get a second pet so that I can 
test 
this myself? If need be, I will just level a warlock up to x level so I can do 
it.

Original comment by step...@smluster.com on 14 Oct 2009 at 2:00

[GoogleCodeExporter]

imp - at level 1
voidwalker - at level 10

Original comment by yo3...@gmail.com on 14 Oct 2009 at 6:22

[GoogleCodeExporter]

'morning

I had a look last night at oUF_ClassIcons addon 
(<http://www.wowinterface.com/downloads/info14349-
oUFClassIcons.html>). They are registering events PARTY_MEMBERS_CHANGED & 
PLAYER_TARGET_CHANGED 
with the Update function. As I don't know how to see what events are triggered 
by an action like pet-
summoning, I played with different PET_* and UNIT_PET events (what looked to me 
that being relevant to 
summoning a pet) but with no reliable success.

Ended up using event UNIT_STATS, which is WRONG, but it worked :(

Original comment by yo3...@gmail.com on 15 Oct 2009 at 7:38

Attachments:

• I47_r52.diff

[GoogleCodeExporter]

This needs to be tested against r53 in which I redesigned the function 
completely. The 
goal was to make it more compatible with oUF_ClassIcons. If you install 
oUF_ClassIcons 
it will get used instead, and my code doesn't get created at all.

Also, I added UNIT_STATS but I commented it out for now. can you test it 
without it, 
and see if it works in your scenario? If it still doesn't, please uncomment the 
UNIT_STATS event in SpartanUI_PlayerFrames/global/Framework.lua and see if it 
works 
when that is enabled.

Original comment by step...@smluster.com on 22 Oct 2009 at 4:55

[GoogleCodeExporter]

I'm running some tests, and unless I enable the UNIT_STATS event or target 
something the class-icon is not 
updated. Don't know how / why I didn't observed it before, but the pet name is 
not updating reliably.

Original comment by yo3...@gmail.com on 22 Oct 2009 at 8:11

[GoogleCodeExporter]

Please find attached the events generated by the following actions:

0) zone-in RFC
0bis) "/etrace start"
          "/etrace" --> to also open event trace window
1) Summon the first pet, with nothing summoned
1bis) "/etrace stop"

2) Write down the events that occur, in order

2bis) "/etrace start"
3) Summon your second pet
3bis) "/etrace stop"

4) Repeast step 2

information extracted by running "/eventrtrace" command from 
"Blizzard_DebugTools" add-on.

Original comment by yo3...@gmail.com on 23 Oct 2009 at 12:19

Attachments:

• pet-summon-EVENTS.rtf

[GoogleCodeExporter]

new execution, this time hanging around in ashenvale.

Original comment by yo3...@gmail.com on 23 Oct 2009 at 9:47

Attachments:

• pet-summon-EVENTS_v2.rtf

[GoogleCodeExporter]

r55; please test this to see if it corrects your problem. I am working on 
getting a 
warlock to 10 so I can reliably test it myself.

Original comment by step...@smluster.com on 25 Oct 2009 at 11:09

[GoogleCodeExporter]

Tested with r57, and the class-icon change looks reliable to me. I have also 
tried switching pets while in combat 
(from imp to voidwalker) and worked also fine.

The only thing I'm still having "problems" is that the pet name is not always 
changing. Any tips on what / how I 
could troubleshoot this?

PS: btw, if you have a hunter with at least 2 pets, switching them in stable 
can also trigger the name problem.

Original comment by yo3...@gmail.com on 26 Oct 2009 at 8:45

[GoogleCodeExporter]

as a temporary fix, I am going to force a name update via the class icon code. 
This is 
a bit hackish though, as there is obviously a problem with the default name 
string in 
oUF. I will have to talk with haste and report the issue.

Original comment by step...@smluster.com on 26 Oct 2009 at 3:14

[GoogleCodeExporter]

tested r57 with oUF_ClassIcons installed, and the icons are a little "ugly" 
(square instead of a nice tiny circle)

Original comment by yo3...@gmail.com on 27 Oct 2009 at 9:16

Attachments:

• sUI+oUF_ClassIcon.jpg

[GoogleCodeExporter]

I had a second look to pet-summon-EVENTS_v2.rtf, and for the last summon (when 
the name was not updated), 
event UNIT_NAME_UPDATE was not triggered; I will do some more eventtraces later 
today, but could this be a 
blizzard bug, or something else?

Original comment by yo3...@gmail.com on 27 Oct 2009 at 11:11

[GoogleCodeExporter]

Yes and no. The default pet frame doesn't have a name, so I have a feeling 
Blizzard 
never encountered this issue. The pet name only shows on the tooltip, which 
queries 
the pet name when you mouseover the pet.

I will take a look at the innards of teh default pet frame to see how they 
handle 
portrait updates, as that MIGHT give us a better picture of the exact events we 
need. I am fairly sure that UNIT_PET and UNIT_CLASSIFICATION_CHANGED are enough 
though. UNIT_CLASSIFICATION_CHANGED is a stopgap to make sure things update for 
hunters, but it may not be needed (and that is something we should test)

I have a bug report in to haste for oUF to look at this issue. It really only 
affects pet frames, so I don't see it being high priority for him, when truth 
be 
told the workaround is dead-simple.

Look for a commit late tonight. I have what I believe to be working code. I am 
level 
8 on my warlock, so hopefully a couple more levels will allow me to test things 
myself.

Original comment by step...@smluster.com on 27 Oct 2009 at 10:19

[GoogleCodeExporter]

please find the (hopefully) last changes I need to make to get this working in 
r58

I was able to test it myself once I got my warlock to level 10 and got the 
voidwalker 
summon. I was able to make the pet name and pet class icon update on pet 
change. Feel 
free to test it yourself, and mark is as Verified when finished, yo3fxy

Original comment by step...@smluster.com on 30 Oct 2009 at 7:14

[GoogleCodeExporter]

Used around 8 shards to do summons from imp to voidwalker or succubus and back 
to imp, and each time 
class-icon & name updated to mach active pet.

Original comment by yo3...@gmail.com on 31 Oct 2009 at 11:40

• Changed state: Verified

[GoogleCodeExporter]

closed due to release of RC8. Any issues regarding the same reports should be 
posted as new issues.

Original comment by step...@smluster.com on 2 Nov 2009 at 2:12

• Changed state: Released