Fix MOTD/Player count on ping passthrough

DragonetMC / DragonProxy

🐲 A proxy to allow Minecraft: Bedrock clients to connect to Minecraft: Java Edition servers.

https://invite.gg/DragonetMC

GNU General Public License v3.0

990 stars 134 forks source link

Fix MOTD/Player count on ping passthrough #511

Closed james090500 closed 4 years ago

james090500 commented 4 years ago

This fixes server showing as offline when ping pass through is enabled.

Noticable changes:

Added subMOTD to replace world name as on LAN games
Removed MOTD from Ping pass through as java MOTD look completely broken on bedrock
Removed version from being added to the end of the MOTD
Ping passthrough now only manages player count

lukeeey commented 4 years ago

I’m not sure I want the world name to change as I think it’s useful to display the version and the software used.

As for the motd, it does sometimes display correctly. I may expand configuration options for it in the future. If you can change the world name back I’ll merge this.

james090500 commented 4 years ago

As requested.

The issue was the java MOTD's have line breaks and everything else. So its cleaner for DP to have it's own MOTD

lukeeey commented 4 years ago

We can work on that in the future and we can make some MOTDs display correctly. Maybe allow regex to replace certain characters (like leading space - remove those and the hypixel motd doesn’t look half bad)