DragonetMC / Dragonet-Legacy

Old version of the Dragonet Server Software.
http://dragonet.org/
Other
101 stars 28 forks source link

Loose coupling between Glowstone++ and Dragonet #128

Closed jlirochon closed 8 years ago

jlirochon commented 8 years ago

When working on re-importing Glowstone++ history and re-applying Dragonet patch (#123) I realized that the patch was quite big, and could be reduced by doing some refactoring.

The patch was making Glowstone++ importing stuff from Dragonet, and both were dependent of each other. It was a nightmare to configure the IDE to handle circular dependencies.

I managed to remove unwanted dependencies by creating Interfaces, and I am still on my way to reduce the overall patch size and make things as clean as possible.

This could take a couple of days since it may requires cooperation of GlowstonePlusPlus and Glowkit projects.

ToDo

DefinitlyEvil commented 8 years ago

Maybe we should make enhanced G++ a PR to them, so it can be benifit to lot of more people. ;)

jlirochon commented 8 years ago

Yes that's what I want to do.

Not sure it can benefit to "lots of people", but it could be a feature of Glowstone++.

Need to talk with @mastercoms to clarify the possibilities. We already talked about being a plugin, but it seems we are interacting at a lower level.

RazvanDu commented 8 years ago

Or... We could make our own server for MCPC just like G++ :p

jlirochon commented 8 years ago

Lol much work involved here

The plugin approach is interesting because it could be compatible with patched official servers too, not only Glowstone++. But I guess existing plugins API are not designed to let plugins handle network connections.

mastercoms commented 8 years ago

https://github.com/aadnk/ProtocolLib

DefinitlyEvil commented 8 years ago

@mastercoms ProtocolLib forced to use Minecraft source(aka NMS) to use network related things but that won't work in Glowstone since it is completely written from scratch.

mastercoms commented 8 years ago

I know, but if you were going the plugin route, you could be a plugin for nms servers, like CraftBukkit or Spigot.

DefinitlyEvil commented 8 years ago

@mastercoms That's true but people only make plugin for Bukkit or NMS, they don't know much about G++ unless we make an NMS interface. :P