Add glob support with dependencies. Fix reload issue

DragonsInn / fontgen-loader

Automated webfont generation from SVG icons. Use with WebPack!

125 stars 42 forks source link

Closed maxaon closed 8 years ago

maxaon commented 8 years ago

Add support for glob in files configuration. Aslo fix reload issue.

Problems:

Using webpack dev server each loader, for correct reloads and validates, should specify dependencies.
For correct reloading loaders should not use require for loading files.

To correctly specify dependencies in pullrequest glob support was added which also add deps. Replaced requre with this.exec

IngwiePhoenix commented 8 years ago

Looks good to me - except that you accidentially left in the output files from the test. I should've put a proper .gitignore there :).

You think you can add one? I'm currently at my parent's, so I am not really able to code :)

But thanks for the PR!

maxaon commented 8 years ago

What files you mean? I've added few svg files in directory 'est/octicon2. test/build already in ignore

IngwiePhoenix commented 8 years ago

The E-Mail I got contained a list of files that looked like build outputs. Awkward, they arent in the commits.

Well, its save to merge, then!

Thanks for the PR...and, appearently, for putting my code to some style (if() to if () etc.)