DragonsPlusMinecraft / CreateEnchantmentIndustry-Fabric

CEI Fabric
https://modrinth.com/mod/create-enchantment-industry-fabric
MIT License
12 stars 13 forks source link

You can put any item into a printer using a funnel, crashing the game. #13

Closed AngelCMHxD closed 1 year ago

AngelCMHxD commented 1 year ago

Minecraft Version

1.19.2

Describe the Bug

If you use a conveyor belt and a funnel (any type), you can put anything inside a printer, and it looks like there isn't any checks to verify if there is actually a book inside. This will results in a crash, however, if you try to access the world again it will crash again because the item is still in the printer, this essentially locks you out of your world.

This is a major bug which could lock everyone out of a multiplayer server and crash it.

Reproduction Steps

⚠️Be warned. This completely disables your world until an update that fixes this gets released, don't try it in a world you actually use.⚠️

  1. Place a printer
  2. Setup a moving conveyor belt with a funnel in order to put items on the printer
  3. Try to place anything besides a book in the printer using the conveyor belt.

Expected Result

The printer will not accept the item, or if it does, it'll just not work instead of crashing.

Screenshots and Videos

(Video speed increased by x2)

Reproducing steps:

https://github.com/DragonsPlusMinecraft/CreateEnchantmentIndustry-Fabric/assets/57822483/2c3b55f7-0bc0-4435-b326-d10f3b1a9dec

Loading crashed world:

https://github.com/DragonsPlusMinecraft/CreateEnchantmentIndustry-Fabric/assets/57822483/dc8d11af-4d6e-4d57-ae8e-70eef5c651da

Crash Report or Log

https://pastebin.com/Zh9775QP

Other Mods

Mod Version

1.0.1