search

DragonsPlusMinecraft / CreateEnchantmentIndustry-Fabric

CEI Fabric
https://modrinth.com/mod/create-enchantment-industry-fabric
MIT License
12 stars 12 forks source link

[1.20.1] [Quilt] Crash on Startup #29

Closed N0aW closed 10 months ago

N0aW commented 10 months ago

Minecraft Version

1.20.1

Describe the Bug

The game starts on startup.

Reproduction Steps

  1. Have the selected mods enabled
  2. Start the game
  3. Error occurs ...

Expected Result

Game boots up and doesn't crash

Screenshots and Videos

No response

Crash Report or Log

https://mclo.gs/lpMB5Fs

Other Mods

No response

Mod Version

1.0.1

IThundxr commented 10 months ago

actually, try 1.2.8

spacky1 commented 10 months ago

Latest version still crashes on Quilt for me as well.

IThundxr commented 10 months ago

Latest version still crashes on Quilt for me as well.

Send a log

spacky1 commented 10 months ago

Here's a log with just Create + Enchantment Industry and QFAPI: https://paste.ee/p/Ql4wN

liamwerk7676 commented 10 months ago

i have the same isue fist i thought it was a isue with https://modrinth.com/mod/create-fabric-sodium-fix but now im sure its quilt im going to try stitching to fabric now

liamwerk7676 commented 10 months ago

yes its incompatible with quilt with fabric it works fine

NolanHewitt commented 10 months ago

Same issue here. Is this something that needs quilt to update to the newer fabric api, or something this mod has to fix to solve?

IThundxr commented 10 months ago

Same issue here. Is this something that needs quilt to update to the newer fabric api, or something this mod has to fix to solve?

It's something between qfapi/qsl & registrate

liamwerk7676 commented 10 months ago

Same issue here. Is this something that needs quilt to update to the newer fabric api, or something this mod has to fix to solve?

It's something between qfapi/qsl & registrate

im going to try and work on a unoficial fix until it gets fixed in the mean time just switch to fabric and disable any quilt mods

nvm i dont know how to code so just switch to fabric until its fixed

TropheusJ commented 10 months ago

This is not an issue with Quilt. CEI is relying on mod load order. This only works on Fabric with pure luck. https://github.com/DragonsPlusMinecraft/CreateEnchantmentIndustry-Fabric/blob/772bedc9f56671656087ccbd992c379e1199a1ad/src/main/java/plus/dragons/createenchantmentindustry/foundation/mixin/AbstractFurnaceBlockEntityMixin.java#L49 if AbstractFurnaceBlockEntity is loaded before CEI registers fluids, this will crash. getSource will get an empty fluid, as it has not been registered yet. Quilt ends up triggering this condition with the item content registries initializer.

IThundxr commented 10 months ago

This is not an issue with Quilt. CEI is relying on mod load order. This only works on Fabric with pure luck.

https://github.com/DragonsPlusMinecraft/CreateEnchantmentIndustry-Fabric/blob/772bedc9f56671656087ccbd992c379e1199a1ad/src/main/java/plus/dragons/createenchantmentindustry/foundation/mixin/AbstractFurnaceBlockEntityMixin.java#L49

if AbstractFurnaceBlockEntity is loaded before CEI registers fluids, this will crash. getSource will get an empty fluid, as it has not been registered yet. Quilt ends up triggering this condition with the item content registries initializer.

Would just removing the field and creating the fluid variant where it's needed fix this?

TropheusJ commented 10 months ago

yes

IThundxr commented 10 months ago

Fixed in latest (1.2.10)