DragonsPlusMinecraft / CreateEnchantmentIndustry

An add-on for Create, providing enchanting & experience related automation.
https://modrinth.com/mod/create-enchantment-industry
MIT License
45 stars 41 forks source link

Experience liquid is tagged for use with other mods, but at a incompatible ratio. #149

Closed Flanks255 closed 8 months ago

Flanks255 commented 8 months ago

Minecraft Version

1.20.1

What Mods Conflicts with

Ender IO, Mob grinding utils, Thermal, Cyclic, Industrial foregoing.

Describe the Incompatibility

The mods Experience liquid is converted at a lower rate(1xp/1mb) then other mods with tagged experience fluids (1xp/20mb).

Off the top of my head.

Cyclic: https://github.com/Lothrazar/Cyclic/blob/trunk/1.20/src/main/java/com/lothrazar/cyclic/block/expcollect/TileExpPylon.java#L43-L44

MGU: https://github.com/vadis365/Mob-Grinding-Utils/blob/MC1.20.1-forge/MobGrindingUtils/MobGrindingUtils/src/main/java/mob_grinding_utils/tile/TileEntityAbsorptionHopper.java#L297-L301

EnderIO: https://github.com/Team-EnderIO/EnderIO/blob/dev/1.20.4/src/main/java/com/enderio/base/common/util/ExperienceUtil.java#L5-L8

Industrial foregoing: https://github.com/InnovativeOnlineIndustries/Industrial-Foregoing/blob/release-1.20/src/main/java/com/buuz135/industrial/block/agriculturehusbandry/tile/MobCrusherTile.java#L189

Thermal expansion has one as well, but i cant remember the name of the machine that collects xp to quote the line.

Other Mods

No response

Additional Context

No response

Crash Report or Log

No response

Mod Version

currently reported / read from source

Incompatible Mod Version

No response

Forge Version

No response

MarbleGateKeeper commented 8 months ago

Experience liquid wasn't designed to be used by other mods. I'll consider this in future.

Flanks255 commented 8 months ago

Ah, sorry, my bad, it appears the fluid is not being tagged on your end, i could have sworn i saw the json in the repo. It seems as though a modpack is tagging the fluid without checking if it is compatible first.