DragonsPlusMinecraft / CreateEnchantmentIndustry

An add-on for Create, providing enchanting & experience related automation.
https://modrinth.com/mod/create-enchantment-industry
MIT License
45 stars 41 forks source link

Unify recipes for converting other types of experience fluid (add by other mods) to Liquid Experience #161

Open AlisonHuang777 opened 7 months ago

AlisonHuang777 commented 7 months ago

Describe the your request

AFAIK, these amounts of experience fluids from other mods can be converted to 10mB of Liquid Experience:

Not only do these recipes not unified on their amounts, but you also need to manually add new recipe to the mod for any new types of experience fluids. Base on this, I suggest this:

for better compatibility.

AlisonHuang777 commented 7 months ago

Well actually, I'm using NeoForge right now, so I'm actually not sure whether #forge:experience exists in Forge or not.

RaymondBlaze commented 7 months ago

Nope, the converting recipes are intended to be not unified due to the fact that different fluid experience not having the same amount of experience.

While using tags for the unofficial convention 20mB per 1xp fluids is possible, but it will still be an internal mod tag with CEI's namespace, instead of forge or the new multiloader conventional namespace c for 1.21, since there're mods adding their experience fluid to the forge tag while not obeying the 20mB convention.

Note that an internal mod tag really won't make much difference for the integration work since expecting mods to add their fluids to other mods' tags is basically the same as expecting them to add the integration recipe themselves. Actually, most of the effort we made on integration is for investigating other mods' ratio on xp fluid/items.

Anyways, thanks for the advice on using tags in the recipe, we'll be looking into it, since reducing the amount of mixing recipes would technically be a bit of optimization.