DragonsPlusMinecraft / Respiteful

MIT License
3 stars 6 forks source link

Compatibility problem with BucketLib #23

Open PhilTheGreatLOL opened 1 month ago

PhilTheGreatLOL commented 1 month ago

When I open inventory in creative mode then game crashed for unexpected error occurred Also tea recipes in JEI are absent too. crash-2024-08-24_00.29.45-client.txt

cech12 commented 1 month ago

It seems that the generated tea fluids of your mod try to return an item called "_bucket". These items does not exist. The same issue seems to occur in other mods as well:

As far as I can see, your tea fluids are generated with a library, which "supports" fluids without buckets by calling a method nobucket(), that is also called: https://github.com/DragonsPlusMinecraft/Respiteful/blob/660d4480dfe74a0a2e617c4858ea7a9b792b01ce/src/main/java/plus/dragons/respiteful/entries/RespitefulFluids.java#L113

This library is Registrate (tterag1098) and there is already a PR which should fix that issue: https://github.com/tterrag1098/Registrate/pull/55 But nothing happens since a year. I opened a new issue: https://github.com/tterrag1098/Registrate/issues/69

To fix the isues, I would recommend to registrate your fluids in a different way by using another library or use the Forge functionalities for this purpose. :)

KooBaby commented 1 month ago

hoping this gets fixed asap now that someone has literally pointed out the exact cause of these issues.