search

DragonsPlusMinecraft / origins-classes-forge

A unofficial Forge port for Origin: Classes
MIT License
7 stars 8 forks source link

Tetra Compat #17

Closed Smartin-b closed 2 years ago

Smartin-b commented 2 years ago

-Tetra Compat -Some additional Tags compatible with Tetra for tooldetection -ignore crashes for some reason in the commit, i forgot to include a dependency in my normal client testing

RaymondBlaze commented 2 years ago

Thanks for the PR! :) There's only one small problem - maybe we should use tags for detection rather than hardcoded ids? I know tags will failed to load if it's entry is missing, but a "require" field could simply fix this.

Smartin-b commented 2 years ago

Tbh im not very experienced with Forge so i dont know, but looking at how Tetra in general manages their items grafik it seemed a lot simpler to detect them with their ids, they dont naturaly have a tag from tetra (Tetrapak is an addon) and that nbt seemed a bit to modular.

Smartin-b commented 2 years ago

Although, unrelated, is it just me or is the Stealth ability of the Rogue just not working? Seems to be the resource detection as far as i can tell