search

Dragoon-Lab / LMS

Learning Management System for Dragoon and Topomath
MIT License
0 stars 0 forks source link

Bug fixes #45

Closed riteshsamala closed 7 years ago

riteshsamala commented 7 years ago
  1. disabling class code link
  2. emptying form parameter z (this was causing the xss issue on chrome for kurts account)
jonwetzel commented 7 years ago

Looks pretty good! Just check for and remove any unnecessary or vague console logs.

jonwetzel commented 7 years ago

...and then we can merge this.

sachingrover211 commented 7 years ago

I have approved the changes, but there is some change needed for database. I am not sure whether it would be useful enough, but the foreign key used by Ritesh for his tables is username - which is unique, but it is not a primary key for users table. Usually the idea is to use the primary key. @jonwetzel I leave it to you to decide if it should be done. There are two points to be considered -

  1. It would mean reworking of the code that was there
  2. The foreign key idea is useful to maintain data integrity, which we might be able to do it from this. I am not sure this has to be tested.

The above two points would be useful to make the decision. After that you can make the card and see what should be the next steps.

sachingrover211 commented 7 years ago

For now I am going to merge the code as it is needed for the classes tomorrow. Rest everything works out fine.