search

Dragoon-Lab / topomath

TopoMath: a web-based algebra tutor
http://topomath.asu.edu
GNU Lesser General Public License v3.0
3 stars 0 forks source link

Schema recon2 #541

Closed riteshsamala closed 4 years ago

riteshsamala commented 4 years ago

Handles issues topomath #367 , #531

jonwetzel commented 4 years ago

@riteshsamala

Found a bug with this branch on tdevel. If you get an equation wrong twice, the node editor doesn't close on your second attempt. It's erroring out in the console with "Assertrion failed: dom.byId failed for " and then "Uncaught TypeError: Cannot read property 'constructor' of null".

Steps: 1) Open "Peregrine Falcon" with parameters given and units skipped. section non-class-models, folder "chapter 1 problems-tca". 2) Create a new equation and select DRT and Dive. 3) Don't change the node names, just hit Done. The node closes and the incorrect nodes are created. The equation is red as expected. 4) Open the equation again. Change DDive to Distance (the correct answer). 5) Click Done. Bug happens.

If this doesn't happen in the branch where students get three attempts, it check it after merging with this one.

jonwetzel commented 4 years ago

@riteshsamala That fixed the bug, but now https://github.com/Dragoon-Lab/topomath/issues/543 doesn't work anymore (which was an earlier commit on this PR).

Follow the same steps as above, then check the model after closing the node. The alien node is still present.

Edit: After further testing we've determined this only happens on touch machines. Will email Kurt to see if that's a showstopper.

jonwetzel commented 4 years ago

Tested thoroughly in trials Feb 15 and before.