search

Dragory / modmailbot

Modmail Bot is a bot for Discord that makes it easier for users to contact moderators and admins for help.
MIT License
708 stars 705 forks source link

Fix typingProxy + Add some features #799

Closed Akinator31 closed 4 months ago

Akinator31 commented 6 months ago

I fixed an issue with the TypingProxy module that just wasn't working at all. The problem was that the "if" which checks that typingProxy is enabled in the config file, was trying to check that the "channel" parameter was an instance of the Eris PrivateChannel class. However, it always returned False due to a problem in Eris's code.

if (config.typingProxy && (channel instanceof Eris.PrivateChannel) TO if (config.typingProxy && !(channel instanceof Eris.GuildChannel))

To solve this problem, I simply checked that the "channel" was not a server message and it worked.

rubyowo commented 6 months ago

You should create separate PRs for different features

Akinator31 commented 6 months ago

Yes but I have to create different fork..

zayKenyon commented 5 months ago

Yes but I have to create different fork..

No you don't! You need to create different branches. Normally master (or main, but master in this case) is preserved with new branches deriving from that. Realistically, if you want to get this merged, you will make life easy for the maintainers and make separate PRs for different features.

I don't know your exact setup but it looks like you're trying to merge your master. I would suggest making a new branch from your latest commit, stashing the secondary features, and then editing your PR to reflect this. You can use these stashed commits to form their own branches, which should become PRs in their own right.

Akinator31 commented 5 months ago

Oh yes, you're right, I'll do that. Thanks for the tip ;)

zayKenyon commented 4 months ago

Thank you, the documentation in #806 is great!

Akinator31 commented 4 months ago

Thank you ;)