search

Drake53 / War3Api

Warcraft III's Common and Blizzard API's in C#.
MIT License
23 stars 4 forks source link

War3Api.Generator.Object should expect latest Warcraft 3 object data #5

Closed YakaryBovine closed 3 years ago

YakaryBovine commented 3 years ago

As per #3, project War3Api.Generator.Object doesn't work with the latest version of Warcraft III. This only has two consequences:

  1. Units do not have the "UnitAbilitySkinList" or "UnitSkinList" fields (though I don't think these do anything).
  2. It makes it difficult to clone the project since it's hard to find Warcraft III object data for older versions.

I can make a PR as this is an easy fix, but as I understand it you are still running 1.31. Is there a way to make the project run with either versions of object data? Alternatively I could fork the project.

Drake53 commented 3 years ago

Thanks for helping make the project compatible with 1.32, since these changes do not conflict with 1.31 compatibility there's no need to fork the project. I hope you don't mind that I used my own commit instead of your PR in this case, because I'd like to keep the exception message in code for reference, and keep the list names sorted.

YakaryBovine commented 3 years ago

Nope, that's perfect, cheers. Your approach makes much more sense.