search

Drakulix / ScrollsModLoader

A Mod Loader Framework for the game "Scrolls" by Mojang
www.scrollsguide.com/summoner
GNU Lesser General Public License v2.1
15 stars 9 forks source link

GameReplayMod fails to playback replays #11

Closed noisecrime closed 10 years ago

noisecrime commented 10 years ago

Think there is an issue with the GameReplayMod as I appear to be unable to play back any replays using it. Accessing a replay via the 'Profile' page, firstly results in some strange screen redraw (like the fade to black pauses) and then once the BattleMode has started I get a 'connection dropped' error which never recovers. This in turn appears to disconnect Scrolls entirely from the server and only restarting will renew the connection.

Having only just installed Summoner I had installed the ScrollsPost.mod and been using its replays extensively. It was only through trying to work out why the gameReplay.mod code didn't seem to tie up with the replay stuff I was seeing ( obvious now I realised that I was using a different replay mod) that I discovered the GameReplay.mod wasn't working.

Can anyone confirm/deny GameReplay.mod has an issue, for reference I'm playing scrolls on a Mac.

It would also be nice if the author could maybe add some text about GameReplay.mod vs ScrollsPost.mod to point out that these are different replay systems. I spent a good hour trying to match up the gameReplay.mod scripts to what I was seeing in game, which unfortunately was the scrollsPost.mod replay system.

I'm wondering whether GameReplay.mod should even be included in ScrollsModLoader, since it may be broken and can easily be confused with other replay mods. I can see it being useful from a learning perspective, but maybe it should be separate?

P.S. Amazing work on getting this done, modding has always been a concern for Unity games and I'm hoping this can lead to some interesting developments.

MaPePeR commented 10 years ago

:+1: for moving the replay mod to a separate repo.

Drakulix commented 10 years ago

GameReplay.mod is more or less discontinued. It broke in one of the last Scrolls updates and ScrollsPost has a lot of additional features, that were missing in GameReplay.mod, so there is not real reason to bring it back.

The source code mainly exists for educational reasons, but thats quite stupid, if it is not even working anymore. I am going to move it to a separate branch and add a little readme, that clarifies, that it is broken and might only be interesting for modders. Once it is moved, I will post a reference here and close this issue.

Drakulix commented 10 years ago

GameReplay.Mod was now moved this repository: https://github.com/Drakulix/GameReplay.Mod It was removed from ScrollsModLoader in https://github.com/Drakulix/ScrollsModLoader/commit/17e86d5a56fd6b4dee592e7f21a306d8c1d63a26