search

Drakulix / fireplace

Modular wayland window manager written in rust
MIT License
603 stars 14 forks source link

Location of config file #30

Closed theduke closed 7 years ago

theduke commented 7 years ago

The XDG / freedesktop guidelines say that the config file should live in a subdirectory of XDG_CONFIG_DIR.

I can dig it out if you want to.

I personally like this. It allows easier expansion and gives a clean structure.

So the default paths checked would be $XDG_CONFIG_DIR/fireplace/fireplace.yml or ~/.config/fireplace/fireplace.yml.

What do you think?

Timidger commented 7 years ago

This is the way Way Cooler does it, and I find that applications that use that folder by default easier to use. I don't have to go rooting around for a configuration file, it's always in the same directory

Drakulix commented 7 years ago

I find all those folders quite annoying, because usually most applications only need one configuration file anyways, but I would be totally fine with searching for that path as well and even using it over the current path.

I just would like to keep the current option, because although it is nice, that there guidelines, and we should totally respect and follow them, this is also a matter of personal preference.

theduke commented 7 years ago

To keep checking ~/.config/fireplace.yml is perfectly fine of course, and is actually pretty much unavoidable since you passed 1.0 already. ;)

Drakulix commented 7 years ago

To keep checking ~/.config/fireplace.yml is perfectly fine of course, and is actually pretty much unavoidable since you passed 1.0 already. ;)

Well the location is considered public api and I am following semver, so I could just increase the major version of course, which I am willing to do, if it provides any benefit (the reason I am already at 3.0 since today). But it is of course bad practice to do that this regularly and completely unnecessary in this case.

I have finally reached a stable config format today, so I really don't want to bump the major version at least for the binary in the near future anymore. ^^

Drakulix commented 7 years ago

Done. Please test and provide feedback once 3.0.2 3.1.0 is tagged and out. (Sometime today)