search

Drakulix / simplelog.rs

Simple Logging Facility for Rust
https://docs.rs/simplelog/
Apache License 2.0
423 stars 71 forks source link

Option to choice between time and chrono #105

Closed jb-alvarado closed 2 years ago

jb-alvarado commented 2 years ago

Hello,

sorry I think I'm a bit late with this question, because you already switch to time and skip chrono. But would be much work to add the option that user can choice between time or chrono? With features this should be possible, or not? I think chrono is now maintained better and many apps depend on it. time brings a dependencies more and for me the formatting options in chrono is more flexible - for example I have not found a way to get milliseconds, like in chrono: %Y-%m-%d %H:%M:%S%.3f, and when it need extra characters like [ there is no escaping necessary.

Drakulix commented 2 years ago

I would consider it, if the general api of simplelog would stay the same and switching between time and chrono would mostly be a feature-toggle.

That said this increases the maintenance burden, as simplelog would need to test and keep up-to-date with multiple date-formatting libraries instead of one. But simplelog is mostly maintained by the community at this point, while I just try to keep it focused. So for me it really depends on the amount added complexity, but I am in general not against this solution. Feel free to experiment and open a PR for further discussion.

jb-alvarado commented 2 years ago

Ok thank you, I understand your point, that it makes it more complex an it must be weighed up whether the effort is worth it.

Maybe I will take a closer look and see if it is possible for me to add a PR.