search

Drakulix / simplelog.rs

Simple Logging Facility for Rust
https://docs.rs/simplelog/
Apache License 2.0
414 stars 71 forks source link

Adjust dependency to support termcolor 1.2 #131

Closed danielparks closed 11 months ago

danielparks commented 1 year ago

The 1.2.0 update to termcolor is backward compatible with the 1.1 versions. This adjusts the version specification for the dependency in Cargo.toml to allow any version greater than or equal to 1.1 and less than 2.0.

This is preventing me from updating termcolor in a few of my crates. The update adds Debug support to a bunch of types, so it’s kind of handy.

I’d be happy to adjust the dependency specification however you like. Personally, I would not be concerned about the author releasing a breaking change without bumping the version past 2.0.

danielparks commented 1 year ago

I added a line to the CHANGELOG, but I’m not sure this is a big enough change to merit that. (I don’t care one way or another about being credited in the CHANGELOG — I just added the credit because it seemed to be the done thing.)

danielparks commented 11 months ago

Rebased. @Drakulix, you you prefer that this limit the termcolor version more? Happy to change it however.

Drakulix commented 11 months ago

Ah sorry, I just missed this (always feel free to ping). Looks good to me. Thanks for putting in the time!

I'll try to find time in the next couple of days to churn through the rest of the PRs and make a new release.

danielparks commented 11 months ago

Rad, thanks. No worries, it wasn’t a top priority.