search

Drakulix / simplelog.rs

Simple Logging Facility for Rust
https://docs.rs/simplelog/
Apache License 2.0
439 stars 73 forks source link

Chrono dependency requirement is too low #28

Closed samueltardieu closed 6 years ago

samueltardieu commented 6 years ago

When using the minimally requested version, chrono 0.4.0 is used which in turns requires num 0.1.0 which does not compile anymore:

   Compiling num v0.1.0
error: expected identifier, found keyword `mod`
  --> /home/sam/.cargo/registry/src/github.com-1ecc6299db9ec823/num-0.1.0/src/bigint.rs:66:16
   |
66 | use std::str::{mod, FromStr};
   |                ^^^ expected identifier, found keyword

Chrono dependency must be bumped to at least 0.4.1. You can test this using cargo-edit and the command cargo update -Z minimal-versions. I suggest adding this to the CI as well.

PR pending.

Drakulix commented 6 years ago

Thanks. I am a bit short on time, I would appreciate another PR adding this to CI.

Drakulix commented 6 years ago

Fix released with v0.5.3.