search

DraqueT / PolyGlot

PolyGlot is a conlang construction toolkit.
MIT License
387 stars 44 forks source link

Replace CustHandler process for loading language xml #1226

Closed DraqueT closed 1 year ago

DraqueT commented 1 year ago

This is a bad system overall. It should be replaced with one that simply walks the nodes and adds values as is necessary/reasonable. It will increase stability and reliability of PolyGlot (and eliminate the issue with deleting spaces before special characters).

pe1uca commented 1 year ago

Just to confirm, this means changing from using org.xml.sax.helpers.DefaultHandler reading characters to using the methods of org.w3c.dom.Node to get child elements and values, correct?

DraqueT commented 1 year ago

Sorry to miss this comment for an extended period! But yes, that is correct. Working on it atm.

pe1uca commented 1 year ago

No problem!

Working on it atm

Oh, so should we discard the PR #1232 ?
There's no need to do double work.