1011 update release package name

synthfi commented 2 weeks ago

Changes

Updated year in LICENSE.txt to 2024
Changed the installer rename process
- no longer renames to a hard-coded constant
- for a release package, uses the package as generated by jpackage
- for a beta package, prepends _BETA_%Y-%m-%d-%H-%M (datetime strftime format) to the file generated by jpackage
Added a command line flag, --type_o, that is forwarded to the call to jpackage --type if it's provided
- in the case of linux, it internally tries to figure out what the underlying system type is based on the contents of /etc/os-release if this flag is not set. I have a machine with both dpkg and rpm installed, which is why

Notes

this allows for release of rpm builds, as the hard-coded path for linux was deb
- the inclusion of the architecture in the file paths is also useful
also keeps the version number in the package, which I like
this is basically a preview of what I'm imagining are going to be the assets in the next release

Example release files	OS environment	Release file name(s)
Linux x86	polyglot-linear-a_3.6-1_amd64.deb polyglot-linear-a-3.6-1.x86_64.rpm
Linux ARM	polyglot-linear-a-3.6-1.aarch64.rpm
OSX ARM	PolyGlot-3.6.dmg
Windows x86	PolyGlot-3.6.exe

Example beta file name	OS environment	Beta file name(s)
Linux x86	_BETA_2024-11-08-15-12_polyglot-linear-a_3.6-1_amd64.deb _BETA_2024-11-08-15-13_polyglot-linear-a-3.6-1.x86_64.rpm
OSX ARM	_BETA_2024-11-08-17-48_PolyGlot-3.6.dmg
Windows x86	_BETA_2024-11-08-14-32_PolyGlot-3.6.9703.exe

How to generate packages (examples)

Release: python3 build_image.py --release --copyDestination .
Beta: python3 build_image.py --copyDestination .

Draft:

[x] testing on osx
[x] testing on windows

synthfi commented 2 weeks ago

want to change the beta release to use a datetime as trapinch has suggested. ~~also go with that on windows instead of uuid~~

synthfi commented 2 weeks ago

@TrapinchO in this commit I added a datetime into the name of a generated beta package. Example output on windows: _BETA_2024-11-08-14-32_PolyGlot-3.6.9703.exe

how does this look to you?

TrapinchO commented 2 weeks ago

@TrapinchO in this commit I added a datetime into the name of a generated beta package. Example output on windows: _BETA_2024-11-08-14-32_PolyGlot-3.6.9703.exe

how does this look to you?

That looks good to me!

By the way, f"{datetime.datetime.now():%Y-%m-%d-%H-%M}" is equivalent to datetime.datetime.now().strftime('%Y-%m-%d-%H-%M') iirc, in case it would interest you.

synthfi commented 2 weeks ago

did not know about that syntax~ I just finished testing on all systems I have for this latest commit, so I'll tack that onto a future PR that is related to the build_image.py

DraqueT / PolyGlot