Closed Tandashi closed 1 year ago
Hey @Tandashi! Sorry for the delay.
I'm working on it, and thank you for reporting the issue 😄
All good. Thanks for the heads up :)
@Tandashi could you try with the PR I opened?
To test it, you can do the following:
npm install
npm link
npm link brackets-manager
Will do in a bit :)
Currently I am running into the problem that
manager.get.currentMatches
only returnsLocked
andCompleted
matches. It doesn't return the matches of the next round as expected.The round contains 3 Matches where Participants have BYE matches (so participant vs no-one) and 1 Participant vs Participant match. Do I need to update the BYE matches manually to mark as completed? (I would assume no if I understand to method Doc correctly)
If that is not the case here is my quick issue analysis. A Match that has a BYE it will always get the status
Locked
(we'll see later why). However themanager.get.currentMatches
function checks if a rounds is completed as follows:Since the
Locked
Status has a value of0
this will never cause the round to be completed, thus returning a list ofLocked
andCompleted
Matches.I would assume that the issue lies somewhere here:
The first
if
check will always cause a Match to get theLocked
Status if it contains aBYE
. ThusisMatchCompleted
, which also accounts for BYE's, will never be reach. Simply returning theCompleted
Status instead of theLocked
one in the first return could already solve the issue.