Drassil / git-wiki-theme

A revolutionary full-featured wiki for github pages and jekyll. You don't need to compile it!
http://drassil.github.io/git-wiki/
MIT License
212 stars 292 forks source link

jekyll build issue under jekyll v3.7.2 #20

Closed overheat closed 6 years ago

overheat commented 6 years ago

Hi,

I can use "jekyll build" and "jekyll serve" to check the result locally on my PC. But I only see a folder tree, when I try git-wiki, like this: http://127.0.0.1:4000/ `

Name Last modified Size
Parent Directory 2018/02/16 23:10 -
404.html 2018/02/16 23:11 2816
LICENSE 2018/02/16 21:57 1078
assets/ 2018/02/16 23:10 -
feed.xml 2018/02/16 23:11 486
index.md 2018/02/16 22:01 12
redirects.json 2018/02/16 23:11 2
robots.txt 2018/02/16 23:11 43
sitemap.xml 2018/02/16 23:11 285
sync-wiki.sh 2018/02/16 21:57 244

`

overheat commented 6 years ago

The log is:

:~/workspace/git-wiki$ jekyll serve --no-watch Configuration file: /mnt/c/Users/aaron/Desktop/workspace/git-wiki/_config.yml Source: /mnt/c/Users/aaron/Desktop/workspace/git-wiki Destination: /mnt/c/Users/aaron/Desktop/workspace/git-wiki/_site Incremental build: disabled. Enable with --incremental Generating... Liquid Warning: Liquid syntax error (line 56): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html Liquid Warning: Liquid syntax error (line 57): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html Liquid Warning: Liquid syntax error (line 58): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html Liquid Warning: Liquid syntax error (line 60): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html Liquid Warning: Liquid syntax error (line 62): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html Liquid Warning: Liquid syntax error (line 64): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html Liquid Warning: Liquid syntax error (line 65): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html done in 0.558 seconds. Auto-regeneration: disabled. Use --watch to enable. Server address: http://127.0.0.1:4000 Server running... press ctrl-c to stop.

Yehonal commented 6 years ago

This wiki is intended to work with github pages that uses jekyll 3.6.2

I never tried to build it locally

Il 17 Feb 2018 01:11, "Aaron Tsui" notifications@github.com ha scritto:

The log is:

:~/workspace/git-wiki$ jekyll serve --no-watch Configuration file: /mnt/c/Users/aaron/Desktop/ workspace/git-wiki/_config.yml Source: /mnt/c/Users/aaron/Desktop/workspace/git-wiki Destination: /mnt/c/Users/aaron/Desktop/workspace/git-wiki/_site Incremental build: disabled. Enable with --incremental Generating... Liquid Warning: Liquid syntax error (line 56): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html Liquid Warning: Liquid syntax error (line 57): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html Liquid Warning: Liquid syntax error (line 58): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html Liquid Warning: Liquid syntax error (line 60): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html Liquid Warning: Liquid syntax error (line 62): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html Liquid Warning: Liquid syntax error (line 64): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html Liquid Warning: Liquid syntax error (line 65): Unexpected character { in "{{{page.folder}}" in /_layouts/default.html done in 0.558 seconds. Auto-regeneration: disabled. Use --watch to enable. Server address: http://127.0.0.1:4000 Server running... press ctrl-c to stop.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Drassil/git-wiki/issues/20#issuecomment-366394840, or mute the thread https://github.com/notifications/unsubscribe-auth/AAI-lG4YeyaUL-hDNoxVGrcuXnXaxttgks5tVhlOgaJpZM4SIeuM .

kpfleming commented 6 years ago

There is a syntax error in all of these locations, and the newer version of Liquid catches it. There are three '{' in a row, when there should only be two. With this changed, Jekyll 3.7.2 has no problem with this theme.

nok-ko commented 6 years ago

@kpfleming Having fixed the syntax errors, the theme still refuses to serve properly on my machine under Jekyll 3.7.3

kpfleming commented 6 years ago

Odd. It's working for me with 3.7.2, haven't had a chance to upgrade to 3.7.3 yet.

sourabhdeshmukh commented 6 years ago

@Yehonal Can you please provide README.md for this repository for Installing or hosting theme locally.

Yehonal commented 6 years ago

@kpfleming could you open a PR to fix that syntax issue please?

@sourabhdeshmukh sorry but i don't use it for local installations so i can't write such guide. But please feel free to open a PR to improve the README if you are able to write a guide for it.