Drassil / git-wiki-theme

A revolutionary full-featured wiki for github pages and jekyll. You don't need to compile it!
http://drassil.github.io/git-wiki/
MIT License
212 stars 293 forks source link

Logo URL cannot be relative #74

Closed nekketsuuu closed 4 years ago

nekketsuuu commented 4 years ago

Describe the bug

_config.yml.dist says that logo_url is "Url of logo image, it can be full, absolute or relative", but it cannot be relative. If the URL is relative, then the logo is not displayed on blog posts which are in subdirectories.

To Reproduce

I used the gh-pages branch of this repository to reproduce.

  1. Change logo_url in _config.yml to be relative.

    --- a/_config.yml
    +++ b/_config.yml
    @@ -9,7 +9,7 @@
     show_wiki_posts: true
     show_wiki_posts_limit: 5
    -logo_url: http://drassil.github.io/git-wiki/assets/images/1200px-Wikipedia-logo-v2.svg_.png
    +logo_url: assets/images/1200px-Wikipedia-logo-v2.svg_.png
     google_analytics:
     git_branch: gh-pages
  2. Go to git-wiki/blog/posts/2018/12/17/first-post.html.

  3. The logo is not displayed. See a screenshot below.

Expected behavior

The logo is displayed correctly.

Screenshots

a logo on upper left is not displayed

Desktop:

Additional context

There are also small issues related to the logo. I noticed:

Yehonal commented 4 years ago

Fixed in https://github.com/Drassil/git-wiki-theme/commit/a882fa29eac28cbb3b21a00e508eef1d93ec29d7