search

DraxCodes / Youtube2Mp3

Take playlists from other sources like Spotify and feed them into Youtube to get either a playable stream or a download for each track as an MP3.
GNU General Public License v3.0
8 stars 2 forks source link

Implement LoadPlaylistAsync #2

Closed svr333 closed 4 years ago

svr333 commented 4 years ago

Fixing #1

I do have to say, for some reason, when copying the url separation thing from my other project, string.Split() started acting weird and I couldn't compile, even though it was perfectly fine. I hope it was just a bug on my end.

Notes:

We might want to create an extension on top of the SpotifyWebApiClient that retrieves an entire playlist by link, instead of retrieving the playlistId from the link and then using the GetPlaylistAsync(playlistId) method.

SpotifyTracks don't have a description so I removed that, added Artists, Album & Duration (will come in handy later on, might add more depending on our needs)

Feedback

If anything is off or something should've been done differently, do tell. First time I'm actually using a proper architecture without being carried around in LiveShare :)

svr333 commented 4 years ago

People can now also use the web link (without the userId provided).

DraxCodes commented 4 years ago

I'm going to merge this because I want to alter a fw things regarding how we have entities setup right now and how the services are setup. Thanks for the hard work though ma dude.

My only real feedback would be a missing new line (LOL) & to extract the url parsing into a private method. Other than that is's balle though.

Ohh and if we're not gonna use UserID, should just be removed for now. I hope you're right regarding the deprication of the GetPlaylistById method though 😂