Draylar / better-dropped-items

https://www.curseforge.com/minecraft/mc-mods/better-dropped-items
Other
13 stars 17 forks source link

Items bobbing in water rotate when hitting the surface #10

Open Zkyo42 opened 4 years ago

Zkyo42 commented 4 years ago

Another minor bug I just noticed, when an item floats on the surface of water, it periodically rotates seemingly randomly each time it reaches the peak of it's bob.

https://www.youtube.com/watch?v=VL5isFpZdA4

skylorbeck commented 4 years ago

I'm not the author but I've been working in the code today. I think that what is happening here is bobbing makes the items out of the water for a tick, which makes it get rotated as the rotate check is looking for "not on ground, not in water"

Draylar commented 4 years ago

mostly fixed in 1.2.4, still have the slight issue of some flat items not reaching the surface before bobbing back down