search

Draylar / fabric-furnaces

A tiered Furnace mod for the Fabric mod loader.
https://minecraft.curseforge.com/projects/fabric-furnaces
MIT License
8 stars 14 forks source link

Vanilla furnace breaks fabric furnace #38

Open cosmoderp opened 3 years ago

cosmoderp commented 3 years ago

I tested this on a world with only fabric API and this mod installed.

how to replicate: Take the ethereal furnace and place it on ground. Place the vanilla furnace on ground anywhere within rendering distance. Place a stack of raw ore and a stack of bamboo as fuel. It will consume the the fuel and produce nothing. It will remain that way even after removing the vanilla furnace.

quick fix: Breaking it and placing it down again fixes this issue even if the vanilla furnace is still there.

notes: If you placed the ethereal furnace and loaded the top slot before placing the vanilla furnace it will continue to work, but as soon as that top slot goes empty and the vanilla furnace that was placed after is still there it will break just the same.

If you place the ethereal furnace after the vanilla one it will work normal.

If the vanilla furnace is outside a rendered area it wont cause this issue.

DaveyL2013 commented 2 years ago

The issue actually seems to apply to placing any furnace, placing any furnace of a different type seems to overwrite some of the stats of every other loaded furnace, and sometimes breaks other things. I can't really tell where the problem is occurring, my best guess is somewhere in the mixin, but I'll try to fix it myself and if I can figure it out I'll make a PR

DaveyL2013 commented 2 years ago

Ok my best guess is that the issue is caused by ff_entityContext being static and I see literally no way to fix this without rewriting the entire mod from scratch so... oh well :/

MJRamon commented 1 year ago

Was this game breaking bug ever fixed?

DaveyL2013 commented 1 year ago

Nope!