search

Draylar / gate-of-babylon

https://www.curseforge.com/minecraft/mc-mods/gate-of-babylon
MIT License
11 stars 18 forks source link

Update to 1.19.2 #92

Closed woalk closed 1 year ago

woalk commented 2 years ago

Rudimentary tests show that this seems to work. I have not tested all mixins extensively.

Alpha release JAR

Coosanta17 commented 1 year ago

Pls fix broken enchantments

MJRamon commented 1 year ago

Pls fix broken enchantments

The fix is to revert changes at lines 29 and 32

Coosanta17 commented 1 year ago

The fix is to revert changes at lines 29 and 32

Did it and it works thanks very much

Here is the fixed jar

bigbluewave commented 1 year ago

Has anyone tried contacting the original author about taking over the mod for the purpose of officially porting it to new Minecraft versions?

I've been working on a new mod to add Mythic Metals versions of all of the Gate of Babylon items (I need to bring it to 1.19.2), so it would be sad to see this mod die. The new fixed 1.19.2 jar should last a while, though.

Once I have my mod working in 1.19.2 I'll put it up on Github, unless someone wants to assist me with updating the version, in which case I'll upload it as is (I had it working alongside All of Fabric 4 for MC 1.17.1). I see that there is an issue related to adding a Mythic Metals extension.

@Draylar Any comment? :)

MJRamon commented 1 year ago

Has anyone tried contacting the original author about taking over the mod for the purpose of officially porting it to new Minecraft versions?

I've been working on a new mod to add Mythic Metals versions of all of the Gate of Babylon items (I need to bring it to 1.19.2), so it would be sad to see this mod die. The new fixed 1.19.2 jar should last a while, though.

Once I have my mod working in 1.19.2 I'll put it up on Github, unless someone wants to assist me with updating the version, in which case I'll upload it as is (I had it working alongside All of Fabric 4 for MC 1.17.1). I see that there is an issue related to adding a Mythic Metals extension.

@Draylar Any comment? :)

It's MIT License, so you don't need to ask a permission

Draylar commented 1 year ago

Has anyone tried contacting the original author about taking over the mod for the purpose of officially porting it to new Minecraft versions?

I've been working on a new mod to add Mythic Metals versions of all of the Gate of Babylon items (I need to bring it to 1.19.2), so it would be sad to see this mod die. The new fixed 1.19.2 jar should last a while, though.

Once I have my mod working in 1.19.2 I'll put it up on Github, unless someone wants to assist me with updating the version, in which case I'll upload it as is (I had it working alongside All of Fabric 4 for MC 1.17.1). I see that there is an issue related to adding a Mythic Metals extension.

@Draylar Any comment? :)

Done and uploaded to CurseForge - thanks for the help, woalk. I'm hoping to do a project rebrand on the CurseForge page to make it look more polished (the pink CF icon has served its time😆), so if you end up publishing a support/compatibility library for GOB, feel free to let me know and I can put a banner on the main CF page for it.

MJRamon commented 1 year ago

Has anyone tried contacting the original author about taking over the mod for the purpose of officially porting it to new Minecraft versions? I've been working on a new mod to add Mythic Metals versions of all of the Gate of Babylon items (I need to bring it to 1.19.2), so it would be sad to see this mod die. The new fixed 1.19.2 jar should last a while, though. Once I have my mod working in 1.19.2 I'll put it up on Github, unless someone wants to assist me with updating the version, in which case I'll upload it as is (I had it working alongside All of Fabric 4 for MC 1.17.1). I see that there is an issue related to adding a Mythic Metals extension. @Draylar Any comment? :)

Done and uploaded to CurseForge - thanks for the help, woalk. I'm hoping to do a project rebrand on the CurseForge page to make it look more polished (the pink CF icon has served its time😆), so if you end up publishing a support/compatibility library for GOB, feel free to let me know and I can put a banner on the main CF page for it.

Enchanting is broken with that commit. We discussed it earlier.

Draylar commented 1 year ago

Enchanting is broken with that commit. We discussed it earlier.

Already fixed with 930259433db5d84071ca6a1e4ea16b9b6481b608 :)

MJRamon commented 1 year ago

Enchanting is broken with that commit. We discussed it earlier.

Already fixed with 9302594 :)

Tested with this fix, didn't work for me for some reason

Draylar commented 1 year ago

Tested with this fix, didn't work for me for some reason

What problem are you running into? Before the patch commit, I could not enchant anything - the table would show results, but I could not click to take anything out of the table. The commit I referenced fixed the problem on my end (but perhaps it is acting differently in production?).

MJRamon commented 1 year ago

Tested with this fix, didn't work for me for some reason

What problem are you running into? Before the patch commit, I could not enchant anything - the table would show results, but I could not click to take anything out of the table. The commit I referenced fixed the problem on my end (but perhaps it is acting differently in production?).

I am sorry, there was a silly mistake on my end. Enchanting is working.

Also, I've made a title logo for you. Use it if it's useful or ignore it if it's not :) https://github.com/Draylar/gate-of-babylon/issues/95