Draylar / get-off-my-lawn

Keep people off your lawn with claims! Built for Fabric.
https://www.curseforge.com/minecraft/mc-mods/get-off-my-lawn
MIT License
4 stars 18 forks source link

TNT placed outside of a claim will still break blocks inside of a claim #2

Open LostQuasar opened 4 years ago

Draylar commented 4 years ago

My latest commit offers 2 checks to prevent TNT griefing:

This works, but there's a bit of desync on the client. This is because ExplosionS2CPacket doesn't send information about the "causing entity", which means the client thinks there was no cause (= good to go, break the blocks!). This should only occur in very rare cases, but I'd still like to patch it before marking this issue as closed.

ExplosionMixin is also currently basically a soft override; ideally, it would be switched to a single inject in the future.

dandin87 commented 3 years ago

AoF 3 2.6.10 Redstone activated TNT dropped from above will destroy blocks in the claim. It also appears that TNT ignited next to the claim will also break blocks inside the claim. Also, Diggus maximus vein mine apparently bypasses claims, which I thought was fixed at some point but is somehow not anymore. Note that we do have Delta Logger and I will try and test without it to see if its interfering.