Draylar / identity

A modern morph mod for Fabric.
https://www.curseforge.com/minecraft/mc-mods/identity
MIT License
105 stars 45 forks source link

[1.20.1] Crash upon opening identity menu #552

Open MrKashew opened 1 year ago

MrKashew commented 1 year ago

Bug description A description of what you expected to happen and what actually happened. Opening Identity menu `

Game log: Upload your game log through hastebin and provide the link. Do not paste the link directly into the submission box or comments. crash-2023-07-05_00.34.15-client.txt crash-2023-07-05_01.14.59-client.txt

karelmikie3 commented 1 year ago

I have the same crash, it happens with only architectury and Identity installed. Versions: Minecraft: 1.20.1 Forge: 47.1.0 Architectury: 9.0.8 Identity: 2.7.0

logs: https://gist.github.com/karelmikie3/02c99522a38b3dccf3fc982bdddcb887

sacu85 commented 1 year ago

I think that this crash is somehow related to Piglin Brute. With architectury-9.0.8-forge.jar and identity-2.7.0-1.20.1-forge.jar installed I get a crash when I open the Identity menu (menu_crash-2023-07-07_23.16.16-client.txt) or spawn a Piglin Brute using an egg (egg_crash-2023-07-07_23.17.10-server.txt). See the attached logs. I use Forge 47.1.0.

egg_crash-2023-07-07_23.17.10-server.txt menu_crash-2023-07-07_23.16.16-client.txt

sacu85 commented 1 year ago

I replaced the draylar\identity\mixin\PiglinBruteBrainMixin.class file from identity-2.7.0-1.20.1-forge.jar with the one from identity-2.6.0-1.19.1-forge.jar. Now everything seems to work correctly. You may try it - I attach the modified jar.

identity-2.7.0-1.20.1-forge_MS.zip

krjencik commented 1 year ago

i downloaded it. No effects.

sacu85 commented 1 year ago

i downloaded it. No effects.

What do you mean? Still the same crash?

Maybe it's a matter of Forge version . I'm using 47.1.0 and my modification works fine.

krjencik commented 1 year ago

oh no.. maybe its some other mod causing my problem....

The game crashed whilst unexpected error Error: java.lang.IllegalAccessError: class divinerpg.entities.vanilla.end.EntityEnderScrounge tried to access private field net.minecraft.world.entity.Entity.f19793 (divinerpg.entities.vanilla.end.EntityEnderScrounge is in module divinerpg@1.0.4 of loader 'TRANSFORMER' @b5312df; net.minecraft.world.entity.Entity is in module minecraft@1.20.1 of loader 'TRANSFORMER' @b5312df)

.... well, it was divine rpg :( Game crashed after pressing the identity menu key ...

sacu85 commented 1 year ago

Good job. How about identity? Does it work when divine rpg is disabled?

krjencik commented 1 year ago

yes im happy

...

just a curious question: will it work one day?

sacu85 commented 1 year ago

You can try submitting an issue at the Divine RPG's forum/GitHub. But I think that you should first wait for the official Identity release working properly in Minecraft 1.20.1.

krjencik commented 1 year ago

ok ty :)

Natedogwoooof commented 1 year ago

Okay I'm checking out the new version after I play some Terraria