Draylar / identity

A modern morph mod for Fabric.
https://www.curseforge.com/minecraft/mc-mods/identity
MIT License
108 stars 46 forks source link

Crashes MC Forge 47.1.47 and MC 1.20.1 #600

Open Mjolinir opened 1 year ago

Mjolinir commented 1 year ago

MC ver: 1.20.1 Forge: 47.1.47 Identity ver: 2.7.1

Crashes during startup, here is the tail end of the error message:

` 12:55:36] [main/INFO]: Replaced 2 calls to Enchantment#getMaxLevel() in net/minecraft/world/inventory/AnvilMenu [12:55:36] [main/INFO]: Patching IForgeItemStack#getEnchantmentLevel [12:55:36] [main/INFO]: Patching IForgeItemStack#getEnchantmentLevel [12:55:36] [main/WARN]: Error loading class: vazkii/quark/content/client/tooltip/AttributeTooltips (java.lang.ClassNotFoundException: vazkii.quark.content.client.tooltip.AttributeTooltips) [12:55:36] [main/WARN]: Error loading class: dev/latvian/mods/kubejs/recipe/RecipesEventJS (java.lang.ClassNotFoundException: dev.latvian.mods.kubejs.recipe.RecipesEventJS) [12:55:36] [main/WARN]: @Mixin target dev.latvian.mods.kubejs.recipe.RecipesEventJS was not found cucumber.mixins.json:RecipeEventJSMixin [12:55:36] [main/INFO]: Initializing MixinExtras via com.llamalad7.mixinextras.service.MixinExtrasServiceImpl(version=0.2.0-rc.4). [12:55:38] [main/INFO]: BeforeConstant is searching for constants in method with descriptor (Lnet/minecraft/network/chat/Component;Z)V [12:55:38] [main/INFO]: BeforeConstant found INTEGER constant: value = 0, intValue = null [12:55:38] [main/INFO]: BeforeConstant found a matching constant TYPE at ordinal 0 [12:55:38] [main/INFO]: BeforeConstant found Insn [ICONST_0] [12:55:38] [main/INFO]: BeforeConstant found INTEGER constant: value = 60, intValue = null [12:55:38] [main/INFO]: BeforeConstant found a matching constant TYPE at ordinal 1 [12:55:38] [main/INFO]: BeforeConstant found IntInsn 60

` Also, Im not using Kubejs or Quark, but I see reference to those in the error for some reason

ToCraft commented 1 year ago

Take a look at #590

Mjolinir commented 1 year ago

Im sorry, I missed that when I looked! I have tried your reference build and it seems to work fine. Thank you!

Man, does it really tale them that long to approve your updates before making them live? You posted that comment over 2 weeks ago! I'm assuming you mean the CurseForge folks, but maybe I'm misunderstanding.

ToCraft commented 1 year ago

Draylar needs to review it and upload it, but I think he's inactive and just porting the mod to new versions instead of merging PRs and similar stuff :(