Draylar / inmis

I need more inventory space! A Fabric backpack mod.
https://www.curseforge.com/minecraft/mc-mods/inmis
MIT License
33 stars 31 forks source link

Crash - actually not sure if it's INMIS, but happens upon opening the backpack #67

Open mahjerion opened 3 years ago

mahjerion commented 3 years ago

https://pastebin.com/n0SJ0P8H

Crash happens when opening the backpacks on a specific player.

This is happening on 1.16.4, Fabric API 0.31.0, on the official Craft to Exile [Harmony] server.

There are 2 bags: blazing backpack, which has some Age of Exile loot, and a endless? backpack that has shulkerboxes.

Thanks so much! Your mod is great :)

Draylar commented 3 years ago

There's basically nothing to go off from that log, so I can't say whether this is Inmis' fault or not. All I can see is that something is failing to serialize (but Inmis backpacks aren't even mentioned in the log, so it could very well be something else). I'll keep the issue open in case anyone has any ideas or new leads.

mahjerion commented 3 years ago

Thanks, appreciate the time. I thought so too. This issue was more of a shot in the dark - maybe I missed something. There was nothing about inmis in the log, but it happened whenever the pack was opened. I'm starting to think though that there's another underlying issue because it just happened but with a Dank instead. Feel free to close it if you feel like it's not your mod

EDIT: closed by accident instead of posting comment

Draylar commented 3 years ago

If the world is reasonably sized and you can send it to me through a file-sharing service, I might able to dev-env the issue out. If you continue to encounter the issue, it might be worth trying.

mahjerion commented 3 years ago

I appreciate it, probably not feasible as the world save is easily 10's of gbs. I'll continue to monitor the situation and see if I notice anything. Thanks for everything!

Infinity081003 commented 3 years ago

I had the same issue recently only after adding a few mods! After looking at the mods in your Pastebin, the culprit has to be "inv-trash-slot-1.0.2.jar"! That seems to be the only mod you also have that I recently added to my mods folder. Every time I open INMIS my game loses connection and crashes.

Infinity081003 commented 3 years ago

@Draylar After further investigation, it seems "inv-trash-slot-1.0.2.jar" may not have been the problem after all. However, the crashing after opening the INMIS backpack does seem to occur less now that it is gone. I'm playing on the fabric 1.17.1 version of the Better Minecraft modpack with a bunch of additional mods. Your mod has been working fine without any crashes until recently I must have added/done something that has caused the game to disconnect from server/crash sooner or later after opening and interacting with the INMIS backpack equipped on my character. I have changed the size of the backpacks via the config recently, but restoring the default config didn't seem to change anything. This is a pastebin of my latest (crash) log: https://pastebin.com/42mKDJKn

The log may look a little weird because the full log was well over the 512kB limit for the free pastebins, so I tried to remove the things I thought were irrelevant. I hope you're able to figure out what is going on! Thanks in advance!

Janfel commented 2 years ago

I’m experiencing a similar crash. Here is the log https://paste.ee/p/uWZjJ. I can also provide you with my world (40 MiB) to reproduce the crash if you’re interested.

Janfel commented 2 years ago

I could reproduce the crash with only Inmis 2.5.2-1.18.2 and Fabric API 0.48.0+1.18.2 on Minecraft 1.18.2. It only happens when opening the backpack using the keyboard shortcut, not when using right-click, but it can be very inconsistent.