Draylar / vanilla-hammers

Introduces 3x3 mining tools for fast digging! Available on 1.14, 1.15, 1.16, and 1.17.
https://minecraft.curseforge.com/projects/vanilla-hammers
MIT License
23 stars 31 forks source link

Update to 1.19.4. #129

Open gniftygnome opened 1 year ago

gniftygnome commented 1 year ago

This requires the updated Magna here: https://github.com/Draylar/magna/pull/28

I've tested Creative inventory and Survival crafting and block breaking, so I think the major features are intact. In some cases where I'm not certain exactly why something is the way it is I've tried to preserve existing behavior. The following items should probably be reviewed.

I'm not sure about changing HammerData.group to be an Identifier. This might affect an API and/or Magna. However, the String name of ItemGroups is only for display as far as I can tell.

I'm also not certain how to replace the functionality of ExtendedHammerItem.isIn(ItemGroup) which overrode a removed vanilla method and may have been the only reason for HammerData.group and HammerData.cachedGroup to exist.