Closed DreadPirateShawn closed 5 years ago
Unclear run steps: Add makefile or similar for tests, perhaps they use pytest?
Difficult to debug: Actual value isn't reported by asserts, simply that it doesn't match expected value, e.g.
FAIL: tests.author_test.TestAuthor.test_gender ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/local/lib/python3.6/dist-packages/nose/case.py", line 198, in runTest self.test(*self.arg) File "/goodreads/tests/author_test.py", line 36, in test_gender assert self.author.gender == 'malt' AssertionError
Many missing asserts: Various tests can never fail because they don't actually assert anything, e.g.
def test_born_at(self): self.author.born_at == '1938/01/10'
Unclear run steps: Add makefile or similar for tests, perhaps they use pytest?
Difficult to debug: Actual value isn't reported by asserts, simply that it doesn't match expected value, e.g.
Many missing asserts: Various tests can never fail because they don't actually assert anything, e.g.