search

DreamItGetIT / statuscake

Go client for statuscake.com
MIT License
16 stars 32 forks source link

Switch ContactID handling back to numeric #24

Closed matschaffer closed 6 years ago

matschaffer commented 6 years ago

As mentioned on https://github.com/DreamItGetIT/statuscake/issues/21#issuecomment-357882903 it looks like statuscake switched this around a bit again.

matschaffer commented 6 years ago

@croman any testing or verification you need help with before merging?

Looks like @AndorCS has a provider ready for the terraform provider that uses this.

AndorCS commented 6 years ago

Everything works for me.

croman commented 6 years ago

@matschaffer Looking now at the documentation, the ContactGroup field seems to be a string, do we still need this PR?

matschaffer commented 6 years ago

I'm pretty sure we need it yes.

@croman the main thing that needs fixing is the ContactID handling.

It appears that statuscake had it as a string, you picked up that change, then they changed it back. The result is now you get marshaling errors even trying to get the state of a test.

It's possible https://github.com/DreamItGetIT/statuscake/pull/24/files#diff-8e127cb80ec48370b10e1df7579a97baR107 is not a change that needs to happen, but seemed cleaner to undo the previous change in its entirety.

croman commented 6 years ago

thanks @matschaffer, merged.