Add ssl tests support - Githubissues

DreamItGetIT / statuscake

Go client for statuscake.com

MIT License

16 stars 32 forks source link

Add ssl tests support #42

Closed gaalexandre closed 5 years ago

gaalexandre commented 5 years ago

In this PR I took @gaetanfl branch and updated it to work on the actual behaviour of the API, in particular creation of SSL tests. Tests were also updated.

croman commented 5 years ago

Thanks for your work on this @alexandreFre. I have two small comments before merging:

Can you replace the fretlink.com links with something more generic (e.g. example.com)?
Running make lint suggests some changes in ssl.go, can you look into that?

gaalexandre commented 5 years ago

Ok i will do that.

gaalexandre commented 5 years ago

@croman I have taken your comment into account thanks for reviewing.

croman commented 5 years ago

Looks good, thanks @alexandreFre