DreamSourceLab / DSView

An open source multi-function instrument for everyone
www.dreamsourcelab.com
GNU General Public License v3.0
1.13k stars 418 forks source link

LIN bus decoder is mixed up with UART:1 decoder #542

Open f-steff opened 2 years ago

f-steff commented 2 years ago

Mixup 1: Add a few UART:1 and a few LIN decoders to a project. Store the configuration. Some of the LIN decoders are converted to UART:1 decoders.

Mixup 2: Add a few UART:1 and a few LIN decoders to a project. Store the configuration. Some of the LIN decoders sometimes disappear. This also results is an error similar to "LIN is not subscribable" in red text on top of the decoder view.

dreamsource-tai commented 2 years ago

@f-steff What is your DSView version?

f-steff commented 1 year ago

@dreamsource-tai Apologies for the late reply. I'm on the latest downloadable version: v1.2.1. Tested primarily on Windows 10 64bit, and very briefly on some MacOS, too, just to confirm the error was also there.

To further elaborate. Exactly what mixup/error occurs is not consistent. Sometimes one change occurs, and other times other changes occur. Storing and restoring a configuration especially seems to trigger the problem, although it appears just using the configuration and removing/adding to it can trigger it, too.

dreamsource-tai commented 1 year ago

@f-steff If you add a sub decoder, its parent decoder will be automatically associated, so you do not need to add a parent decoder.

shidong-z commented 1 year ago

In the LIN protocol, there is a problem with the PID resolution, the seventh and eighth bits are the check bit, and the check bit appears later. image