search

DreamWeave-MP / CoreScripts

The serverside Lua scripts used to implement core functionality in S3MP.
MIT License
0 stars 1 forks source link

refactor: added notation and sorted out some bad code #40

Closed YvanCywan closed 1 year ago

HotaruBlaze commented 1 year ago

customCommandHooks is one of the scripts being tweaked heavily rn for the new scriptloader, probably best to wait for that code to be finished before doing annotations there imo.

https://github.com/DreamWeave-MP/CoreScripts/pull/26

magicaldave commented 1 year ago

We can just provide new ones alongside, saint's already got them mostly set up for these files.

HotaruBlaze commented 1 year ago

I suppose, just seems like it'd be messy commit wise, because your gonna need to pull those changes in, then update them again anyway.

YvanCywan commented 1 year ago

I suppose, just seems like it'd be messy commit wise, because your gonna need to pull those changes in, then update them again anyway.

Even if they get replaced and we need to handle merge conflicts, I'd rather have these in now and deal with the conflicts myself later.